ashb commented on a change in pull request #11462:
URL: https://github.com/apache/airflow/pull/11462#discussion_r503866421
##########
File path: airflow/models/dag.py
##########
@@ -1842,16 +1842,17 @@ def deactivate_stale_dags(expiration_date,
session=None):
:type expiration_date: datetime
:return: None
"""
- for dag in session.query(
- DagModel).filter(DagModel.last_scheduler_run < expiration_date,
- DagModel.is_active).all():
+ query = session.query(DagModel).filter(DagModel.last_scheduler_run <
expiration_date,
Review comment:
Oooh crap, I don't update this column anymore on master, so I don't
think this is right. But there also isn't any global setting I do update
anymore.
Even SerialzedDag.updated_at might not be right, as if the dag hasn't
changed, that value won't be updated anymore.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
