vsoch commented on issue #4846: [AIRFLOW-4030] adding start to singularity for airflow URL: https://github.com/apache/airflow/pull/4846#issuecomment-472199552 Here are the linting issues - strange that there are files not touched in this pull request, I will fix these too. ```bash ./tests/contrib/operators/test_singularity_operator.py:21:1: F401 'logging' imported but unused ./tests/contrib/operators/test_singularity_operator.py:28:1: F401 'AirflowException' imported but unused ./tests/contrib/operators/test_singularity_operator.py:55:62: W291 trailing whitespace ./tests/contrib/operators/test_singularity_operator.py:56:71: W291 trailing whitespace ./tests/contrib/hooks/test_cassandra_hook.py:89:124: E261 at least two spaces before inline comment ./tests/cli/test_worker_initialisation.py:35:28: E261 at least two spaces before inline comment ./airflow/configuration.py:556:15: E261 at least two spaces before inline comment ./airflow/contrib/operators/singularity_operator.py:20:1: F401 'json' imported but unused ./airflow/contrib/operators/singularity_operator.py:76:20: E251 unexpected spaces around keyword / parameter equals ./airflow/contrib/operators/singularity_operator.py:76:22: E251 unexpected spaces around keyword / parameter equals ./airflow/contrib/operators/singularity_operator.py:101:25: E711 comparison to None should be 'if cond is None:' ./airflow/contrib/operators/singularity_operator.py:107:66: W291 trailing whitespace ./airflow/contrib/operators/singularity_operator.py:112:16: F821 undefined name 'pull_folder' ./airflow/contrib/operators/singularity_operator.py:112:28: E711 comparison to None should be 'if cond is not None:' ./airflow/contrib/operators/singularity_operator.py:113:43: F821 undefined name 'pull_folder' ./airflow/contrib/operators/singularity_operator.py:116:57: F841 local variable 'host_tmp_dir' is assigned to but never used ./airflow/contrib/operators/singularity_operator.py:123:33: E711 comparison to None should be 'if cond is not None:' ./airflow/contrib/operators/singularity_operator.py:125:1: W293 blank line contains whitespace ./airflow/contrib/operators/singularity_operator.py:134:58: W291 trailing whitespace ./airflow/contrib/operators/singularity_operator.py:145:53: W291 trailing whitespace ./airflow/contrib/utils/gcp_field_validator.py:136:1: F401 'Callable' imported but unused ./airflow/contrib/kubernetes/pod_launcher.py:23:1: F401 'Pod' imported but unused ./airflow/contrib/kubernetes/kubernetes_request_factory/pod_request_factory.py:19:1: F401 'Pod' imported but unused ./airflow/executors/__init__.py:24:57: E261 at least two spaces before inline comment ./airflow/macros/__init__.py:22:16: E261 at least two spaces before inline comment ./airflow/macros/__init__.py:23:26: E261 at least two spaces before inline comment ./airflow/macros/__init__.py:24:12: E261 at least two spaces before inline comment ./airflow/macros/__init__.py:25:19: E261 at least two spaces before inline comment ./airflow/macros/__init__.py:26:12: E261 at least two spaces before inline comment ./airflow/models/__init__.py:4650:46: E261 at least two spaces before inline comment ./airflow/www/views.py:1875:34: E261 at least two spaces before inline comment ```
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
