elvijs commented on a change in pull request #4603: [AIRFLOW-3717] Use DAG context managers in documentation examples URL: https://github.com/apache/airflow/pull/4603#discussion_r264925236
########## File path: docs/concepts.rst ########## @@ -759,25 +759,22 @@ For example, consider the following dag: from airflow.utils.trigger_rule import TriggerRule - dag = DAG( - dag_id='latest_only_with_trigger', - schedule_interval=dt.timedelta(hours=4), - start_date=dt.datetime(2016, 9, 20), - ) + with DAG(dag_id='latest_only_with_trigger', + schedule_interval=dt.timedelta(hours=4), + start_date=dt.datetime(2016, 9, 20)) as dag: Review comment: No, we don't, good spot! I'll fix when I get the time (probably this weekend) ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
