r39132 commented on a change in pull request #4835: [AIRFLOW-XXX] Improvements
to formatted content in documentation
URL: https://github.com/apache/airflow/pull/4835#discussion_r264926576
##########
File path: docs/howto/write-logs.rst
##########
@@ -127,12 +128,12 @@ example:
#. Verify that logs are showing up for newly executed tasks in the bucket
you've defined.
#. Verify that the Google Cloud Storage viewer is working in the UI. Pull up a
newly executed task, and verify that you see something like:
- .. code-block:: bash
+.. code-block:: bash
- *** Reading remote log from gs://<bucket where logs should be
persisted>/example_bash_operator/run_this_last/2017-10-03T00:00:00/16.log.
- [2017-10-03 21:57:50,056] {cli.py:377} INFO - Running on host
chrisr-00532
- [2017-10-03 21:57:50,093] {base_task_runner.py:115} INFO - Running:
['bash', '-c', u'airflow run example_bash_operator run_this_last
2017-10-03T00:00:00 --job_id 47 --raw -sd
DAGS_FOLDER/example_dags/example_bash_operator.py']
- [2017-10-03 21:57:51,264] {base_task_runner.py:98} INFO - Subtask:
[2017-10-03 21:57:51,263] {__init__.py:45} INFO - Using executor
SequentialExecutor
- [2017-10-03 21:57:51,306] {base_task_runner.py:98} INFO - Subtask:
[2017-10-03 21:57:51,306] {models.py:186} INFO - Filling up the DagBag from
/airflow/dags/example_dags/example_bash_operator.py
+ *** Reading remote log from gs://<bucket where logs should be
persisted>/example_bash_operator/run_this_last/2017-10-03T00:00:00/16.log.
+ [2017-10-03 21:57:50,056] {cli.py:377} INFO - Running on host chrisr-00532
+ [2017-10-03 21:57:50,093] {base_task_runner.py:115} INFO - Running: ['bash',
'-c', u'airflow run example_bash_operator run_this_last 2017-10-03T00:00:00
--job_id 47 --raw -sd DAGS_FOLDER/example_dags/example_bash_operator.py']
+ [2017-10-03 21:57:51,264] {base_task_runner.py:98} INFO - Subtask:
[2017-10-03 21:57:51,263] {__init__.py:45} INFO - Using executor
SequentialExecutor
+ [2017-10-03 21:57:51,306] {base_task_runner.py:98} INFO - Subtask:
[2017-10-03 21:57:51,306] {models.py:186} INFO - Filling up the DagBag from
/airflow/dags/example_dags/example_bash_operator.py
-Note the top line that says it's reading from the remote log file.
+**Note** that the first line that says it's reading from the remote log file.
Review comment:
Readability ... `that .. that`? Remove the second `that`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
