turbaszek commented on a change in pull request #11113:
URL: https://github.com/apache/airflow/pull/11113#discussion_r504208365



##########
File path: 
airflow/providers/greatexpectations/operators/greatexpectations_base.py
##########
@@ -0,0 +1,30 @@
+from airflow.models import BaseOperator
+
+
+class GreatExpectationsBaseOperator(BaseOperator):

Review comment:
       > the base operator could implement a generic load data context + load 
batch + validation
   
   I agree with that, the base operator should implement methods that can be 
reused in other more specific operators. It should also implement some error 
handling as well as auth part if necessary 




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to