ashb commented on pull request #10617: URL: https://github.com/apache/airflow/pull/10617#issuecomment-708515603
Basically my concern here is that this is a lot of code, and not all python modules are safe to just delete from sys.module (specifically things with compiled components might not be happy with this) -- and the following two constraints should already hold in 1.10.12 with DAG serialization enabled, or in 2.0.0 always: - When parsing a dag file, it is done in a "single-use" process that parses one file, then exits. - When executing a task, the same caveat should apply - the dag is never loaded in a long-running/persistent python process. So my worry is this is a lot of code and "messing about" in python internals that serves no end in 2.0.0 and onwards. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
