mik-laj commented on a change in pull request #11533:
URL: https://github.com/apache/airflow/pull/11533#discussion_r504965212
##########
File path: chart/templates/create-user-job.yaml
##########
@@ -57,14 +57,6 @@ spec:
- name: {{ template "registry_secret" . }}
{{- end }}
containers:
- - name: run-airflow-migrations
Review comment:
The code is under high-level testing, but that doesn't mean we shouldn't
think about lower-level testing. I don't have much experience testing Helm
Chart yet, but if you change the behavior of the code, the tests should also be
updated.
I am able to imagine that our test could consist in generating the YAML code
and checking only the type and name of the resource. That would be enough
because we would know that these resources are really being created.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
