ashb commented on a change in pull request #11542:
URL: https://github.com/apache/airflow/pull/11542#discussion_r505487150
##########
File path: airflow/models/dag.py
##########
@@ -1347,8 +1347,18 @@ def __deepcopy__(self, memo):
result._log = self._log
return result
- def sub_dag(self, task_regex, include_downstream=False,
- include_upstream=True):
+ def sub_dag(self, *args, **kwargs):
+ """This method is deprecated in favor of partial_subset"""
+ warnings.warn(
+ "This method is deprecated and will be removed in a future
version. Please use partial_subset",
+ DeprecationWarning,
+ stacklevel=2,
Review comment:
I kind of didn't on purpose - it's so rare to be used, and the
UPDATING.md is so large already, and anyone who does will get a Depreciation
warning whilst the code still works so...
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
