potix2 commented on a change in pull request #11531:
URL: https://github.com/apache/airflow/pull/11531#discussion_r505812440
##########
File path: airflow/providers/google/cloud/hooks/gcs.py
##########
@@ -260,7 +260,9 @@ def rewrite(
destination_bucket.name, # type: ignore[attr-defined]
)
- def download(self, object_name: str, bucket_name: Optional[str], filename:
Optional[str] = None) -> str:
+ def download(
+ self, object_name: str, bucket_name: Optional[str], filename:
Optional[str] = None
+ ) -> Union[str, bytes]:
Review comment:
This method returns downloaded content as `bytes` or filename as
`string`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
