ashb commented on a change in pull request #11566:
URL: https://github.com/apache/airflow/pull/11566#discussion_r506552192
##########
File path: airflow/operators/bash.py
##########
@@ -72,6 +72,10 @@ class BashOperator(BaseOperator):
users in the Web UI. Most of the default template variables are not at
risk.
+ Add a space after the script name when directly calling a Bash script
with the
+ ``bash_command`` argument. This is because Airflow tries to apply a
Jinja template to it,
+ which will fail.
Review comment:
```suggestion
Add a space after the script name when directly calling a a ``.sh``
script with the
``bash_command`` argument -- for example
``bash_command="my_script.sh "``. This
is because Airflow tries to apply load this file and process it as a
Jinja template to
it ends with ``.sh``, which will likely not be what most users want.
```
##########
File path: airflow/operators/bash.py
##########
@@ -72,6 +72,10 @@ class BashOperator(BaseOperator):
users in the Web UI. Most of the default template variables are not at
risk.
+ Add a space after the script name when directly calling a Bash script
with the
+ ``bash_command`` argument. This is because Airflow tries to apply a
Jinja template to it,
+ which will fail.
+
Review comment:
You've placed this in the middle of a warning, it needs to be moved else
where, perhaps above the `.. wanring::` and in to a `.. note::` block
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
