ashb commented on a change in pull request #4859: [AIRFLOW-3917] Added config 
to support running scheduler(with kuberne…
URL: https://github.com/apache/airflow/pull/4859#discussion_r265034847
 
 

 ##########
 File path: airflow/contrib/kubernetes/kube_client.py
 ##########
 @@ -48,4 +48,10 @@ def _load_kube_config(in_cluster, cluster_context, 
config_file):
 def get_kube_client(in_cluster=conf.getboolean('kubernetes', 'in_cluster'),
                     cluster_context=None,
                     config_file=None):
+    if cluster_context is None \
+       and conf.get('kubernetes', 'cluster_context'):
+        cluster_context = conf.get('kubernetes', 'cluster_context')
 
 Review comment:
   ```diff
   +    if not in_cluster:
   +        if cluster_context is None
   +            cluster_context = conf.get('kubernetes', 'cluster_context', 
fallback=None)
   +        if config_file is None:
   +            config_file = conf.get('kubernetes', 'config_file', 
fallback=None)
        return _load_kube_config(in_cluster, cluster_context, config_file)
   ```

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to