kaxil commented on a change in pull request #11535:
URL: https://github.com/apache/airflow/pull/11535#discussion_r507187187
##########
File path: scripts/ci/libraries/_build_images.sh
##########
@@ -519,8 +519,8 @@ function build_images::build_ci_image() {
" >"${DETECTED_TERMINAL}"
spinner::spin "${OUTPUT_LOG}" &
SPIN_PID=$!
- # shellcheck disable=SC2064
- traps::add_trap "kill ${SPIN_PID} || true" INT TERM HUP EXIT
+ # shellcheck disable=SC2064,SC2016
+ traps::add_trap '$(kill '${SPIN_PID}' || true)' EXIT HUP INT TERM
Review comment:
Example with single quote:
```
❯ a="x"
❯ echo '$a'
$a
❯ echo '${a}'
${a}
❯ echo "${a}"
x
❯ e
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
