ashb commented on a change in pull request #4772: [AIRFLOW-3937]
KubernetesPodOperator support for envFrom configMapRef…
URL: https://github.com/apache/airflow/pull/4772#discussion_r265058038
##########
File path: airflow/contrib/kubernetes/pod.py
##########
@@ -114,3 +118,4 @@ def __init__(
self.hostnetwork = hostnetwork or False
self.tolerations = tolerations or []
self.security_context = security_context
+ self.envs_from_configmaps = envs_from_configmaps or []
Review comment:
The other variable is just called `secrets` - so maybe we just call this
`configmaps`? I think with the doc string you already have this would be clear
enough.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
