potiuk commented on pull request #11541: URL: https://github.com/apache/airflow/pull/11541#issuecomment-711436884
If any of you around: https://github.com/apache/airflow/pull/11641 cc: @ephraimbuddy It turned out that using just merge_commit_sha is not enough. The logic of github as understand it now (nowhere to be seen): 1) If you have one commit directly from master -> merge_commit_sha = null, github.sha = your change 2) If you have two commits directly from master or even single one not from master -> merge_commit_sha = merge_commit, github.sha = your latest commit ¯\_(ツ)_/¯ So the logic I have to implement: if merge_commit_sha != null -> use merge_commit_sha else use github.sha ¯\_(ツ)_/¯ ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
