ashb commented on a change in pull request #11219:
URL: https://github.com/apache/airflow/pull/11219#discussion_r507490408
##########
File path: airflow/kubernetes/refresh_config.py
##########
@@ -24,15 +24,22 @@
import logging
import os
import time
-from datetime import datetime
from typing import Optional
+import pendulum
import yaml
from kubernetes.client import Configuration
from kubernetes.config.exec_provider import ExecProvider
from kubernetes.config.kube_config import KUBE_CONFIG_DEFAULT_LOCATION,
KubeConfigLoader
+def _parse_timestamp(ts_str: str) -> int:
+ parsed_dt = pendulum.parse(ts_str)
+ if isinstance(parsed_dt, pendulum.DateTime):
Review comment:
Ah, `cast` from the typing module or a `# type:` comment is probably the
way to go then
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
