ashb commented on a change in pull request #11627:
URL: https://github.com/apache/airflow/pull/11627#discussion_r507597027
##########
File path: airflow/__init__.py
##########
@@ -18,9 +18,9 @@
#
"""
-Authentication is implemented using flask_login and different environments can
-implement their own login mechanisms by providing an `airflow_login` module
-in their PYTHONPATH. airflow_login should be based off the
+Authentication is implemented using flask_login and different environments can
implement their own login mechanisms by providing an `airflow_login` module in
their PYTHONPATH.
Review comment:
This line is too long. Please wrap at 110 characters.
##########
File path: airflow/__init__.py
##########
@@ -18,9 +18,9 @@
#
"""
-Authentication is implemented using flask_login and different environments can
-implement their own login mechanisms by providing an `airflow_login` module
-in their PYTHONPATH. airflow_login should be based off the
+Authentication is implemented using flask_login and different environments can
implement their own login mechanisms by providing an `airflow_login` module in
their PYTHONPATH.
+
+airflow_login should be based off the
`airflow.www.login`
Review comment:
```suggestion
airflow_login should be based off the ``airflow.www.login``
```
##########
File path: airflow/cli/commands/task_command.py
##########
@@ -220,6 +221,8 @@ def task_run(args, dag=None):
@cli_utils.action_logging
def task_failed_deps(args):
"""
+ task_failed_deps.
Review comment:
```suggestion
List which dependencies are failing (stopping execution) for a given
TaskInstance.
```
##########
File path: airflow/configuration.py
##########
@@ -228,8 +227,8 @@ def _validate(self):
def _validate_config_dependencies(self):
"""
- Validate that config values aren't invalid given other config values
- or system-level limitations and requirements.
+ Validate that config values aren't invalid given other config values
or system-level limitations and requirements.
+
Review comment:
Previous form was fine/correct.
##########
File path: airflow/example_dags/example_branch_python_dop_operator_3.py
##########
@@ -17,8 +17,7 @@
# under the License.
"""
-Example DAG demonstrating the usage of BranchPythonOperator with
depends_on_past=True, where tasks may be run
-or skipped on alternating runs.
+Example DAG demonstrating the usage of BranchPythonOperator with
depends_on_past=True, where tasks may be run or skipped on alternating runs.
Review comment:
Revert this -- previous one was fine.
##########
File path: airflow/configuration.py
##########
@@ -53,9 +53,8 @@
def expand_env_var(env_var):
"""
- Expands (potentially nested) env vars by repeatedly applying
- `expandvars` and `expanduser` until interpolation stops having
- any effect.
+ Expands (potentially nested) env vars by repeatedly applying `expandvars`
and `expanduser` until interpolation stops having any effect.
+
Review comment:
The previous version was fine as it was.
##########
File path: airflow/configuration.py
##########
@@ -986,6 +985,8 @@ def get_custom_secret_backend() ->
Optional[BaseSecretsBackend]:
def initialize_secrets_backends() -> List[BaseSecretsBackend]:
"""
+ initialize_secrets_backends
Review comment:
```suggestion
Initialize configured and built-in secrets backends
```
##########
File path: airflow/dag/base_dag.py
##########
@@ -88,6 +100,8 @@ def dag_ids(self):
@abstractmethod
def get_dag(self, dag_id):
"""
+ get_dag.
+
:return: whether the task exists in this bag
Review comment:
```suggestion
Get a DAG from this bag, if it exists, or else return None.
```
##########
File path: airflow/cli/commands/webserver_command.py
##########
@@ -46,6 +46,8 @@
class GunicornMonitor(LoggingMixin):
"""
+ GunicornMonitor
+
Review comment:
```suggestion
```
The existing first paragraph _was_ a good summary.
##########
File path: airflow/dag/base_dag.py
##########
@@ -48,6 +52,8 @@ def task_ids(self):
@abstractmethod
def full_filepath(self):
"""
+ full_filepath.
+
:return: The absolute path to the file that contains this DAG's
definition
Review comment:
```suggestion
The absolute path to the file that contains this DAG's definition
```
##########
File path: airflow/dag/base_dag.py
##########
@@ -57,6 +63,8 @@ def full_filepath(self):
@abstractmethod
def concurrency(self):
"""
+ concurrency.
+
:return: maximum number of tasks that can run simultaneously from this
DAG
Review comment:
```suggestion
Maximum number of tasks that can run simultaneously from this DAG
```
##########
File path: airflow/dag/base_dag.py
##########
@@ -65,6 +73,8 @@ def concurrency(self):
@abstractmethod
def pickle_id(self):
"""
+ pickle_id.
+
:return: The pickle ID for this DAG, if it has one. Otherwise None.
Review comment:
```suggestion
The pickle ID for this DAG, if it has one, otherwise None.
```
##########
File path: airflow/example_dags/example_external_task_marker_dag.py
##########
@@ -17,8 +17,7 @@
# under the License.
"""
-Example DAG demonstrating setting up inter-DAG dependencies using
ExternalTaskSensor and
-ExternalTaskMarker
+Example DAG demonstrating setting up inter-DAG dependencies using
ExternalTaskSensor and ExternalTaskMarker
Review comment:
```suggestion
Example DAG demonstrating setting up inter-DAG dependencies using
ExternalTaskSensor and ExternalTaskMarker.
```
##########
File path: airflow/dag/base_dag.py
##########
@@ -80,6 +90,8 @@ class BaseDagBag:
@abstractmethod
def dag_ids(self):
"""
+ dag_ids.
+
:return: a list of DAG IDs in this bag
Review comment:
```suggestion
A list of DAG IDs in this bag
```
##########
File path: airflow/dag/base_dag.py
##########
@@ -39,6 +41,8 @@ def dag_id(self):
@abstractmethod
def task_ids(self):
"""
+ task_ids.
+
:return: A list of task IDs that are in this DAG
Review comment:
```suggestion
A list of task IDs that are in this DAG
```
##########
File path: airflow/contrib/operators/file_to_gcs.py
##########
@@ -31,7 +31,8 @@
class FileToGoogleCloudStorageOperator(LocalFilesystemToGCSOperator):
"""
- This class is deprecated.
+ This class is deprecated
Review comment:
```suggestion
This class is deprecated.
```
##########
File path: airflow/dag/base_dag.py
##########
@@ -30,6 +30,8 @@ class BaseDag(metaclass=ABCMeta):
@abstractmethod
def dag_id(self):
"""
+ dag_id.
+
:return: the DAG ID
Review comment:
```suggestion
The DAG ID
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
