ashb commented on a change in pull request #10884:
URL: https://github.com/apache/airflow/pull/10884#discussion_r507652212
##########
File path: airflow/utils/log/logging_mixin.py
##########
@@ -90,6 +90,14 @@ def __init__(self, logger, level):
self.level = level
self._buffer = ''
+ def close(self):
+ """
+ Provide close method, for compatibility with the io.IOBase interface.
+
+ This is a no-op method.
+ """
+ pass
Review comment:
```suggestion
```
Not needed (and sadly not liked by pylint) because the doc-comment is a
statement.
Or open a PR to disable the `unnecessary-pass` rule globally, as I do like
the "clarity" of an explicit pass here.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
