TobKed commented on a change in pull request #8553:
URL: https://github.com/apache/airflow/pull/8553#discussion_r508221739
##########
File path: airflow/providers/google/cloud/hooks/dataflow.py
##########
@@ -496,17 +517,15 @@ def start_java_dataflow(
variables['jobName'] = name
variables['region'] = location
- def label_formatter(labels_dict):
- return ['--labels={}'.format(
- json.dumps(labels_dict).replace(' ', ''))]
+ if 'labels' in variables:
+ variables['labels'] = json.dumps(variables['labels']).replace(' ',
'')
Review comment:
@jaketf do you know maybe are these regexes are used for labels by all
google apis?
I see that google provides a comprehensive information when labels do not
comply with these regex, with regex included, however we could make validation
of labels for whole google provider and throw some warning to the user (before
it fails during run).
WDYT @jaketf @mik-laj
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
