FloChehab commented on issue #11657: URL: https://github.com/apache/airflow/issues/11657#issuecomment-713089816
Hello, I come from https://github.com/apache/airflow/pull/11681#issuecomment-712790910 . So a bit of feedback on the experience with the current setup: * The hardest part was for me to install the helm plugin (which doesn't seem to be maintained much ; I ended up on the fork https://github.com/quintush/helm-unittest) * Maybe add a bit of documentation in the chart's README (the Overview in the description of this issue is pretty nice) on the steps needed to run the tests locally, * It's really slow to run, * It's nice to be able to test template files individually, * I feel it's ok to test with yaml ; but it's not very flexible (let's say I wanted to add a test that checks that after rendering, if `kerberos.enabled=false`, then `kerberos` is not present in any of the templates, ...) Going for something a bit more custom with golang or python will enable easier "advance" tests (this chart has some very complex logic, so I have a feeling that it's going to be useful). And on Golang vs Python, I'd agree with: > What are the benefits of Golang in our case? The potential popularity with other contributors is a benefit, but I don't see them being active in the development of this Helm Chart. Rather, new features are being added by active contributors to the project who are already familiar with Python. However, if someone is not familiar with Python, writing new tests should not be a challenge for him, because Python is simpler than golang. I think some small "internal" python testing logic like what I can see in #11693 is nice. It will also enable easy debugging, etc. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
