jhtimmins commented on a change in pull request #11362:
URL: https://github.com/apache/airflow/pull/11362#discussion_r509601362
##########
File path: airflow/www/views.py
##########
@@ -859,8 +895,12 @@ def rendered(self):
title=title)
@expose('/get_logs_with_metadata')
- @has_dag_access(can_dag_read=True)
- @has_access
+ @auth.has_access([
+ (permissions.ACTION_CAN_READ, permissions.RESOURCE_DAGS),
+ (permissions.ACTION_CAN_READ, permissions.RESOURCE_TASK_INSTANCE),
+ (permissions.ACTION_CAN_READ, permissions.RESOURCE_LOG),
Review comment:
Are you saying that this endpoint shouldn't check for can_read on Logs?
Because this is the `get_logs_with_metadata` endpoint
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
