potiuk commented on a change in pull request #11630: URL: https://github.com/apache/airflow/pull/11630#discussion_r510048893
########## File path: provider_packages/SETUP_TEMPLATE.py.jinja2 ########## @@ -0,0 +1,101 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. + +# NOTE! THIS FILE IS AUTOMATICALLY GENERATED AND WILL BE\ +# OVERWRITTEN WHEN RUNNING +# +# ./breeze prepare-provider-readme +# +# IF YOU WANT TO MODIFY IT, YOU SHOULD MODIFY THE TEMPLATE +# `SETUP_TEMPLATE.py.jinja2` IN the `provider_packages` DIRECTORY + +"""Setup.py for the {{ PACKAGE_PIP_NAME }} package.""" + +import io +import logging +import os +import sys + +from os.path import dirname +from setuptools import find_packages, setup + +logger = logging.getLogger(__name__) + +version = '{{RELEASE_NO_LEADING_ZEROS}}' + +my_dir = dirname(__file__) + +try: + with io.open(os.path.join(my_dir, + '{{ PROVIDER_PATH }}/{{ README_FILE }}'), + encoding='utf-8') as f: + long_description = f.read() +except FileNotFoundError: + long_description = '' + + +def do_setup(version_suffix=''): + """ + Perform the package setup. + """ + setup( + name='{{ PACKAGE_PIP_NAME }}', + description='{{ PROVIDER_TYPE }} package {{ PACKAGE_PIP_NAME }} for Apache Airflow', + long_description=long_description, + long_description_content_type='text/markdown', + license='Apache License 2.0', + version=version + version_suffix, + packages=find_packages( + include=['airflow.providers.{{ PROVIDER_PACKAGE_ID }}*']), + zip_safe=False, + install_requires={{ INSTALL_REQUIREMENTS }}, + setup_requires={{ SETUP_REQUIREMENTS }}, + extras_require={{ EXTRAS_REQUIREMENTS }}, + classifiers=[ + 'Development Status :: 5 - Production/Stable', + 'Environment :: Console', + 'Environment :: Web Environment', + 'Intended Audience :: Developers', + 'Intended Audience :: System Administrators', + 'License :: OSI Approved :: Apache Software License', + 'Programming Language :: Python :: 3.6', + 'Programming Language :: Python :: 3.7', + 'Programming Language :: Python :: 3.8', + 'Topic :: System :: Monitoring', + ], + author='Apache Software Foundation', + author_email='[email protected]', + url='http://airflow.apache.org/', + download_url=( + 'https://dist.apache.org/repos/dist/release/airflow/{{ PROVIDERS_FOLDER }}' + version), + python_requires='~=3.6', + ) + + +if __name__ == "__main__": + suffix='' + if len(sys.argv) == 1: + print("ERROR! Missing first param", file=sys.stderr) + sys.exit(1) + if sys.argv[1] == "--version-suffix": + if len(sys.argv) < 3: + print("ERROR! --version-suffix needs parameter!", file=sys.stderr) + sys.exit(1) + suffix = sys.argv[2] + sys.argv = [sys.argv[0]] + sys.argv[3:] + do_setup(version_suffix=suffix) Review comment: Sure I can bake it in for alphas, no problem. But I will leave an option to modify it manually for RCs. I use the same setup approach for backports and I prefer to add rc suffixes when generating the RCs rather than manually modifying the sources during the builds as it happens currently. Effectively we are releasing tio PyPI packages that haave slightly modified sources vs. the ones we actually put in SVN. I will rename the switch as "--pypi-rc-suffix" though to be perfectly clear about it's usage. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
