TobKed commented on a change in pull request #11726:
URL: https://github.com/apache/airflow/pull/11726#discussion_r510332168
##########
File path: airflow/providers/google/cloud/hooks/dataflow.py
##########
@@ -268,9 +271,8 @@ def _check_dataflow_job_state(self, job) -> bool:
raise Exception("Google Cloud Dataflow job {} has
failed.".format(job['name']))
elif DataflowJobStatus.JOB_STATE_CANCELLED == job['currentState']:
raise Exception("Google Cloud Dataflow job {} was
cancelled.".format(job['name']))
- elif (
- DataflowJobStatus.JOB_STATE_RUNNING == job['currentState']
- and DataflowJobType.JOB_TYPE_STREAMING == job['type']
+ elif DataflowJobStatus.JOB_STATE_RUNNING == job['currentState'] and (
Review comment:
If I understand correctly, this allow to preserve backward compatibility
and give great options of configuration to the user. Awesome.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
