potiuk commented on a change in pull request #11750:
URL: https://github.com/apache/airflow/pull/11750#discussion_r510354864
##########
File path: scripts/in_container/_in_container_script_init.sh
##########
@@ -19,10 +19,10 @@
set -euo pipefail
# This should only be sourced from in_container directory!
-IN_CONTAINER_DIR="$( cd "$( dirname "${BASH_SOURCE[0]}" )" && pwd )"
+in_container_dir="$( cd "$( dirname "${BASH_SOURCE[0]}" )" && pwd )"
Review comment:
```suggestion
IN_CONTAINER_DIR="$( cd "$( dirname "${BASH_SOURCE[0]}" )" && pwd )"
readonly IN_CONTAINER_DIR
```
##########
File path: scripts/in_container/_in_container_script_init.sh
##########
@@ -19,10 +19,10 @@
set -euo pipefail
# This should only be sourced from in_container directory!
-IN_CONTAINER_DIR="$( cd "$( dirname "${BASH_SOURCE[0]}" )" && pwd )"
+in_container_dir="$( cd "$( dirname "${BASH_SOURCE[0]}" )" && pwd )"
# shellcheck source=scripts/in_container/_in_container_utils.sh
-. "${IN_CONTAINER_DIR}/_in_container_utils.sh"
+. "${in_container_dir}/_in_container_utils.sh"
Review comment:
```suggestion
. "${IN_CONTAINER_DIR}/_in_container_utils.sh"
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
