michalmisiewicz commented on a change in pull request #11745:
URL: https://github.com/apache/airflow/pull/11745#discussion_r510391076
##########
File path: airflow/www/app.py
##########
@@ -66,8 +66,16 @@ def create_app(config=None, testing=False,
app_name="Airflow"):
flask_app = Flask(__name__)
flask_app.secret_key = conf.get('webserver', 'SECRET_KEY')
- session_lifetime_days = conf.getint('webserver', 'SESSION_LIFETIME_DAYS',
fallback=30)
- flask_app.config['PERMANENT_SESSION_LIFETIME'] =
timedelta(days=session_lifetime_days)
+ if conf.has_option('webserver', 'SESSION_LIFETIME_DAYS'):
+ warnings.warn('SESSION_LIFETIME_DAYS option is deprecated. Please use
`SESSION_LIFETIME_MINUTES`',
+ DeprecationWarning)
+
+ if conf.has_option('webserver', 'FORCE_LOG_OUT_AFTER'):
+ warnings.warn('FORCE_LOG_OUT_AFTER option is deprecated. Please use
`SESSION_LIFETIME_MINUTES`',
Review comment:
I believe that we should warn user about removed options. Warning can be
removed in next Airflow release.
I can changed message to `option is removed. Please use ...`
Please let me know if I should remove this warning.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
