mik-laj commented on a change in pull request #11742:
URL: https://github.com/apache/airflow/pull/11742#discussion_r510440451
##########
File path: airflow/www/extensions/init_views.py
##########
@@ -73,8 +73,14 @@ def init_plugins(app):
appbuilder = app.appbuilder
for view in plugins_manager.flask_appbuilder_views:
- log.debug("Adding view %s", view["name"])
- appbuilder.add_view(view["view"], view["name"],
category=view["category"])
+ try:
+ log.debug("Adding view %s with menu", view["name"])
+ appbuilder.add_view(view["view"], view["name"],
category=view["category"])
+ except KeyError as e:
+ if e.args[0] == 'name':
Review comment:
What is the expected behavior if the user does not provide the "view"
key? It seems to me that in this case the exception will be silenced. It seems
to me that in this case the exception will be silenced.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
