ryanahamilton commented on a change in pull request #11652:
URL: https://github.com/apache/airflow/pull/11652#discussion_r511152027
##########
File path: airflow/www/templates/airflow/dags.html
##########
@@ -78,9 +78,48 @@ <h2>DAGs</h2>
<th width="12">
<span id="pause_header" class="material-icons text-muted"
title="Use this toggle to pause a DAG. The scheduler won't schedule new tasks
instances for a paused DAG. Tasks already running at pause time won't be
affected.">info</span>
</th>
- <th>DAG</th>
- <th>Schedule</th>
- <th>Owner</th>
+ <th>
+ <a href="{{ url_for('Airflow.index',
status=request.args.get('status', 'all'), search=request.args.get('search',
None), tags=request.args.get('tags', None), sortBy='dag_id', orderBy='asc' if
request.args.get('sortBy') != 'dag_id' or request.args.get('orderBy', 'desc')
!= 'asc' else 'desc' ) }}">
+ DAG
+ <span class="material-icons">
+ {% if request.args.get('orderBy', 'none') == 'desc' and
request.args.get('sortBy') == 'dag_id' %}
+ expand_less
+ {% elif request.args.get('orderBy', 'none') == 'asc' and
request.args.get('sortBy') == 'dag_id' %}
+ expand_more
+ {% else %}
+ unfold_more
+ {% endif %}
+ </span>
+ </a>
Review comment:
Ah, yes. Given the text-to-icon strategy employed, we should add
`aria-hidden="true"` to the `<span />`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
