mik-laj commented on a change in pull request #11736:
URL: https://github.com/apache/airflow/pull/11736#discussion_r511159676



##########
File path: airflow/providers/hashicorp/secrets/vault.py
##########
@@ -44,11 +44,11 @@ class VaultBackend(BaseSecretsBackend, LoggingMixin):
     would be accessible if you provide ``{"connections_path": "connections"}`` 
and request
     conn_id ``smtp_default``.
 
-    :param connections_path: Specifies the path of the secret to read to get 
Connections
-        (default: 'connections').
+    :param connections_path: Specifies the path of the secret to read to get 
Connections.
+        (default: 'connections'). Note that if set to None (null), requests 
for connections will not be sent to Vault.

Review comment:
       ```suggestion
           (default: 'connections'). If set to None (null), requests for 
connections will not be sent to Vault.
   ```

##########
File path: airflow/providers/hashicorp/secrets/vault.py
##########
@@ -44,11 +44,11 @@ class VaultBackend(BaseSecretsBackend, LoggingMixin):
     would be accessible if you provide ``{"connections_path": "connections"}`` 
and request
     conn_id ``smtp_default``.
 
-    :param connections_path: Specifies the path of the secret to read to get 
Connections
-        (default: 'connections').
+    :param connections_path: Specifies the path of the secret to read to get 
Connections.
+        (default: 'connections'). Note that if set to None (null), requests 
for connections will not be sent to Vault.
     :type connections_path: str
-    :param variables_path: Specifies the path of the secret to read to get 
Variables
-        (default: 'variables').
+    :param variables_path: Specifies the path of the secret to read to get 
Variable.
+        (default: 'variables'). Note that if set to None (null), requests for 
variables will not be sent to Vault.

Review comment:
       ```suggestion
           (default: 'variables'). If set to None (null), requests for 
variables will not be sent to Vault.
   ```




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to