mik-laj commented on a change in pull request #11802:
URL: https://github.com/apache/airflow/pull/11802#discussion_r511296867
##########
File path: tests/cli/commands/test_kubernetes_command.py
##########
@@ -40,3 +43,90 @@ def test_generate_dag_yaml(self):
self.assertEqual(len(os.listdir(out_dir)), 6)
self.assertTrue(os.path.isfile(out_dir + file_name))
self.assertGreater(os.stat(out_dir + file_name).st_size, 0)
+
+ @mock.patch('kubernetes.client.CoreV1Api.delete_namespaced_pod')
+ def test_delete_pod(self, delete_namespaced_pod):
+ kubernetes_command._delete_pod('dummy', 'awesome-namespace')
+ delete_namespaced_pod.assert_called_with(body=mock.ANY, name='dummy',
namespace='awesome-namespace')
+
+ @mock.patch('airflow.cli.commands.kubernetes_command._delete_pod')
+ @mock.patch('kubernetes.client.CoreV1Api.list_namespaced_pod')
+ @mock.patch('kubernetes.config.load_incluster_config')
+ def test_cleanup_succeeded_pods(self, load_incluster_config,
list_namespaced_pod, delete_pod):
+ pod1 = MagicMock()
+ pod1.metadata.name = 'dummy'
+ pod1.status.phase = 'Succeeded'
+ pod1.status.reason = None
+ list_namespaced_pod().items = [pod1]
+ kubernetes_command.cleanup_pods(
+ self.parser.parse_args(['kubernetes', 'cleanup-pods',
'--namespace', 'awesome-namespace'])
+ )
+ delete_pod.assert_called_with('dummy', 'awesome-namespace')
+ load_incluster_config.assert_called_once()
+
+ @mock.patch('airflow.cli.commands.kubernetes_command._delete_pod')
+ @mock.patch('kubernetes.client.CoreV1Api.list_namespaced_pod')
+ @mock.patch('kubernetes.config.load_incluster_config')
+ def test_no_cleanup_failed_pods_wo_restart_policy_never(
+ self, load_incluster_config, list_namespaced_pod, delete_pod
+ ):
+ pod1 = MagicMock()
+ pod1.metadata.name = 'dummy2'
+ pod1.status.phase = 'Failed'
+ pod1.status.reason = None
+ pod1.spec.restart_policy = 'Always'
+ list_namespaced_pod().items = [pod1]
+ kubernetes_command.cleanup_pods(
+ self.parser.parse_args(['kubernetes', 'cleanup-pods',
'--namespace', 'awesome-namespace'])
+ )
+ delete_pod.assert_not_called()
+ load_incluster_config.assert_called_once()
+
+ @mock.patch('airflow.cli.commands.kubernetes_command._delete_pod')
+ @mock.patch('kubernetes.client.CoreV1Api.list_namespaced_pod')
+ @mock.patch('kubernetes.config.load_incluster_config')
+ def test_cleanup_failed_pods_w_restart_policy_never(
+ self, load_incluster_config, list_namespaced_pod, delete_pod
+ ):
+ pod1 = MagicMock()
+ pod1.metadata.name = 'dummy3'
+ pod1.status.phase = 'Failed'
+ pod1.status.reason = None
+ pod1.spec.restart_policy = 'Never'
+ list_namespaced_pod().items = [pod1]
+ kubernetes_command.cleanup_pods(
+ self.parser.parse_args(['kubernetes', 'cleanup-pods',
'--namespace', 'awesome-namespace'])
+ )
+ delete_pod.assert_called_with('dummy3', 'awesome-namespace')
+ load_incluster_config.assert_called_once()
+
+ @mock.patch('airflow.cli.commands.kubernetes_command._delete_pod')
+ @mock.patch('kubernetes.client.CoreV1Api.list_namespaced_pod')
+ @mock.patch('kubernetes.config.load_incluster_config')
+ def test_cleanup_evicted_pods(self, load_incluster_config,
list_namespaced_pod, delete_pod):
+ pod1 = MagicMock()
+ pod1.metadata.name = 'dummy4'
+ pod1.status.phase = 'Failed'
+ pod1.status.reason = 'Evicted'
+ pod1.spec.restart_policy = 'Never'
+ list_namespaced_pod().items = [pod1]
+ kubernetes_command.cleanup_pods(
+ self.parser.parse_args(['kubernetes', 'cleanup-pods',
'--namespace', 'awesome-namespace'])
+ )
+ delete_pod.assert_called_with('dummy4', 'awesome-namespace')
+ load_incluster_config.assert_called_once()
+
+ @mock.patch('airflow.cli.commands.kubernetes_command._delete_pod')
+ @mock.patch('kubernetes.client.CoreV1Api.list_namespaced_pod')
+ @mock.patch('kubernetes.config.load_incluster_config')
+ def test_cleanup_api_exception_continue(self, load_incluster_config,
list_namespaced_pod, delete_pod):
Review comment:
can you add a test for a pod that was skipped, e.g. is currently running?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
