ashb commented on a change in pull request #4916: [AIRFLOW-4087] remove sudo in
on_finish function of BaseTaskRunner
URL: https://github.com/apache/airflow/pull/4916#discussion_r265772956
##########
File path: airflow/task/task_runner/base_task_runner.py
##########
@@ -161,4 +161,4 @@ def on_finish(self):
A callback that should be called when this is done running.
"""
if self._cfg_path and os.path.isfile(self._cfg_path):
- subprocess.call(['sudo', 'rm', self._cfg_path], close_fds=True)
+ subprocess.call(['rm', self._cfg_path], close_fds=True)
Review comment:
We still need this when `self.run_as_user is Not None`
```suggestion
if self.run_as_user:
subprocess.call(['rm', self._cfg_path], close_fds=True)
else:
os.remove(self._cfg_path)
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
