ashb commented on a change in pull request #11589:
URL: https://github.com/apache/airflow/pull/11589#discussion_r512603098
##########
File path: airflow/models/dagrun.py
##########
@@ -466,7 +475,35 @@ def update_state(
session.merge(self)
- return ready_tis, callback
+ return schedulable_tis, callback
+
+ @provide_session
+ def task_instance_scheduling_decisions(self, session: Session = None) ->
_TISchedulingDecision:
+
+ schedulable_tis: List[TI] = []
+ changed_tis = False
+
+ tis = list(self.get_task_instances(session=session,
state=State.task_states + (State.SHUTDOWN,)))
+ self.log.debug("number of tis tasks for %s: %s task(s)", self,
len(tis))
+ for ti in tis:
+ ti.task = self.get_dag().get_task(ti.task_id)
+
+ unfinished_tasks = [t for t in tis if t.state in State.unfinished]
+ finished_tasks = [t for t in tis if t.state in State.finished |
{State.UPSTREAM_FAILED}]
Review comment:
```suggestion
finished_tasks = [t for t in tis if t.state in State.finished]
```
I added UPSTREAM_FAILED in to `finished` in a PR that's already been merged.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
