potiuk edited a comment on pull request #11828:
URL: https://github.com/apache/airflow/pull/11828#issuecomment-717485938
OK. We have it working with @TobKed. Please take a look. I'd love to merge
it for tomorrow to see whether we will have some improvements even before
moving to self-hosted runners.
It works as follows (and I will describe it in separate PR):
* by default when PR is not approved only "Default" variants of matrix are
run as tests.
* when a committer approves the PR (generally when the state changes to
"approved by all committers who reviewed) the PR review workflow is run and it
* sets the label to "ok to test" and
* adds the comment, that you should rebase or rerun the workflow to run
all the test
Also a new check is added that will remain "in-progress" until you actually
rebase the request or commiter re-runs the check:
I think at this point we might even decide to merge such request in case of
simple changes that do not introduce too big of a risk. Maybe even we can
change the comment to explicitly say so and leave the decision to committer.
* When someone rebases/reruns such PR with "okay to test" label, it will run
with full suite of tests. This will continue with every rebase until some
commiter "request changes" - in which case the label will be removed and the PR
will return back to "selected tests only".
* It is a bit different for "doc-only" PRs that do not run any tests. When
commiter approves the PR the PR gets "okay to merge" label and comment
indicating that the PR can be merged:
And it can be merged immediately
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
