[
https://issues.apache.org/jira/browse/AIRFLOW-4095?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16793428#comment-16793428
]
ASF GitHub Bot commented on AIRFLOW-4095:
-----------------------------------------
yaswanthrajyadiki commented on pull request #4920: [AIRFLOW-4095] Adding some
params as template fields in S3 Operators
URL: https://github.com/apache/airflow/pull/4920
Make sure you have checked _all_ steps below.
### Jira
- [x] My PR addresses the following [Airflow
4095](https://issues.apache.org/jira/browse/AIRFLOW-4095) issue
### Description
Added below attributes as template_fields, now those params will accept
Jinja template and values will changes in run time
S3DeleteObjectsOperator
1. keys
2. bucket
S3CopyObjectOperator
1. source_bucket_key
2. dest_bucket_key
3. source_bucket_name
4. dest_bucket_name
### Commits
- [ ] My commits all reference Jira issues in their subject lines, and I
have squashed multiple commits if they address the same issue. In addition, my
commits follow the guidelines from "[How to write a good git commit
message](http://chris.beams.io/posts/git-commit/)":
1. Subject is separated from body by a blank line
1. Subject is limited to 50 characters (not including Jira issue reference)
1. Subject does not end with a period
1. Subject uses the imperative mood ("add", not "adding")
1. Body wraps at 72 characters
1. Body explains "what" and "why", not "how"
### Documentation
- [x] In case of new functionality, my PR adds documentation that describes
how to use it.
- When adding new operators/hooks/sensors, the autoclass documentation
generation needs to be added.
- All the public functions and the classes in the PR contain docstrings
that explain what it does
- If you implement backwards incompatible changes, please leave a note in
the [Updating.md](https://github.com/apache/airflow/blob/master/UPDATING.md) so
we can assign it to a appropriate release
### Code Quality
- [x] Passes `flake8`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Adding some params as template fields in S3 Operators
> -----------------------------------------------------
>
> Key: AIRFLOW-4095
> URL: https://issues.apache.org/jira/browse/AIRFLOW-4095
> Project: Apache Airflow
> Issue Type: Improvement
> Components: aws, operators
> Reporter: Yaswanth Raj Kumar Yadiki
> Assignee: Yaswanth Raj Kumar Yadiki
> Priority: Major
> Labels: easy-fix, features
>
> In S3DeleteObjectsOperator and S3CopyObjectOperator, there were some params
> to be modified in run time when we use Jinja template as values to them. They
> are
> S3DeleteObjectsOperator
> # keys
> # bucket
> S3CopyObjectOperator
> # source_bucket_key
> # dest_bucket_key
> # source_bucket_name
> # dest_bucket_name
> By this change, when ever we use those two operator and if we use some of the
> above parameters values with Jinja templating, then the values of the above
> params will be changed in run time according to the Jinja
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
