potiuk commented on a change in pull request #12038:
URL: https://github.com/apache/airflow/pull/12038#discussion_r515950284
##########
File path: scripts/ci/selective_ci_checks.sh
##########
@@ -518,20 +549,8 @@ get_count_www_files
get_count_kubernetes_files
calculate_test_types_to_run
-if [[ ${image_build_needed} == "true" ]]; then
- set_basic_checks_only "false"
-else
- set_basic_checks_only "true"
-fi
-
-if [[ ${tests_needed} == "true" ]]; then
- run_tests "true"
-else
- run_tests "false"
-fi
-
-if [[ ${kubernetes_tests_needed} == "true" ]]; then
- run_kubernetes_tests "true"
-else
- run_kubernetes_tests "false"
-fi
+set_image_build "${image_build_needed}"
+set_basic_checks_only "${image_build_needed}"
Review comment:
Ah errror here :(
##########
File path: scripts/ci/selective_ci_checks.sh
##########
@@ -518,20 +549,8 @@ get_count_www_files
get_count_kubernetes_files
calculate_test_types_to_run
-if [[ ${image_build_needed} == "true" ]]; then
- set_basic_checks_only "false"
-else
- set_basic_checks_only "true"
-fi
-
-if [[ ${tests_needed} == "true" ]]; then
- run_tests "true"
-else
- run_tests "false"
-fi
-
-if [[ ${kubernetes_tests_needed} == "true" ]]; then
- run_kubernetes_tests "true"
-else
- run_kubernetes_tests "false"
-fi
+set_image_build "${image_build_needed}"
+set_basic_checks_only "${image_build_needed}"
Review comment:
Fixed
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
