turbaszek commented on a change in pull request #11778:
URL: https://github.com/apache/airflow/pull/11778#discussion_r515906811
##########
File path: airflow/operators/dagrun_operator.py
##########
@@ -38,7 +39,8 @@ class TriggerDagRunLink(BaseOperatorLink):
name = 'Triggered DAG'
def get_link(self, operator, dttm):
- return
f"/graph?dag_id={operator.trigger_dag_id}&root=&execution_date={quote(dttm.isoformat())}"
+ view = conf.get('webserver', 'dag_default_view').lower()
+ return
f"/{view}?dag_id={operator.trigger_dag_id}&root=&execution_date={quote(dttm.isoformat())}"
Review comment:
When using `base_url` in the url and using breeze I'm redirected to
`localhost:8080` instead of `0.0.0.0:28080`. So I think we don't have to use it
it in url.
When using `url_for` then the link doesn't work at all
##########
File path: airflow/operators/dagrun_operator.py
##########
@@ -38,7 +38,8 @@ class TriggerDagRunLink(BaseOperatorLink):
name = 'Triggered DAG'
def get_link(self, operator, dttm):
- return
f"/graph?dag_id={operator.trigger_dag_id}&root=&execution_date={quote(dttm.isoformat())}"
+ query = {"dag_id": operator.trigger_dag_id, "root": "",
"execution_date": dttm.isoformat()}
+ return build_airflow_url_with_query(query)
Review comment:
Please see
https://github.com/apache/airflow/pull/11778#discussion_r515906811
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
