tomasfarias commented on pull request #11964: URL: https://github.com/apache/airflow/pull/11964#issuecomment-721487330
@eladkal I agree, any unit smaller than hour is probably not something you'd be able to match reliably anyways 😓. I like your idea, and I've also allowed for either the upper bound or the lower bound to be set as `None`, but not both, to allow for unilateral comparisons, for example: if `target_upper` is `None` and the current `datetime` falls above `target_lower` then return true branch. This also reduces the number of arguments, which was getting unnecessarily out of control as @mik-laj suggested. Branch has been rebased as @kaxil asked. I'm was having a bit of trouble getting the docs build to pass: now docs build passes locally, so I'm expecting it to pass with the latest commit. Thanks all for reviews and input 💪 ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
