astahlman commented on issue #4787: [AIRFLOW-3967] Extract Jinja directive from 
Javascript
URL: https://github.com/apache/airflow/pull/4787#issuecomment-473576523
 
 
   I'd love to see this get merged.
   
   In https://github.com/apache/airflow/pull/4893 (adding time-zone support on 
the UI), I've also been wrestling with how to invoke Javascript functions with 
Jinja-templated variables supplied by the server as arguments. The approach I 
settled on was to expose these functions in a webpack library and invoke them 
from inline scripts 
([example](https://github.com/apache/airflow/pull/4893/files#diff-14ced8e8f63f4412cf931e72002b3049R370)).
   
   The approach in this PR seems cleaner though, since it gets rid of inline 
scripting altogether.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to