potiuk commented on pull request #12092: URL: https://github.com/apache/airflow/pull/12092#issuecomment-722313601
Very good change indeed. I was thinking about getting rid of it and as of recently (when we added CodeQL workflow following the documentation of Github, we realized that we can use HEAD^1 and fetch depth to achieve this and we already used in several new actions that we developed with Tobiasz. The learning we had was that we can rely on HEAD^1 being the "target" of the merge, because it could be either HEAD^1 or HEAD^2 in merge requests, depends which is the direction of the merge performed by GitHub. But since they are using it in their own actions (for CodeQL to determine the head of PR) https://github.com/github/codeql-action we've learned we can rely on it. This was not obvious as Github does not explain how they are doing the merges and the CI_SOURCE_REPO etc is I think the last remnant of Travis (it was initially implemented there as their merging strategy was much different than the GitHub one). ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
