potiuk commented on a change in pull request #12114:
URL: https://github.com/apache/airflow/pull/12114#discussion_r518318789
##########
File path: scripts/ci/selective_ci_checks.sh
##########
@@ -475,8 +475,9 @@ function get_count_kubernetes_files() {
echo
local pattern_array=(
"^airflow/kubernetes"
+ "^airflow/executors/kubernetes_executor.py"
Review comment:
It's harmful here. That will exclude
""^airflow/executors/kubernetes_executor.py" from "core".
The "core" of airflow is defined as everything that is not defined in one of
the selection criteria before:
```
COUNT_CORE_OTHER_CHANGED_FILES=$((COUNT_ALL_CHANGED_FILES -
COUNT_WWW_CHANGED_FILES - COUNT_PROVIDERS_CHANGED_FILES -
COUNT_CLI_CHANGED_FILES - COUNT_API_CHANGED_FILES -
COUNT_KUBERNETES_CHANGED_FILES))
```
This means that any "airflow/executors/kubernetes_executor.py" is treated
as CORE/OTHER and it will trigger all tests (including Kubernetes tests). There
are likely a number of unit tests depending on any change in the
"airflow/executors" package, so if we change anything in this package, we have
to run all tests
On the other hand, if ONLY files in "kubernetest_tests" change - we should
only run kubernetes tests.
I reviewed it and there is another error here in fact We should not add
"^airflow/kubernetes" here in the first place because there are some
"kubernetes" unit tests (from "tests/kubernetes" folder) that could be skipped
by accident if the "^airflow/kubernetes" only is changed).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
