ashb commented on a change in pull request #12082:
URL: https://github.com/apache/airflow/pull/12082#discussion_r518887900
##########
File path: .pre-commit-config.yaml
##########
@@ -438,6 +438,17 @@ repos:
files: ^airflow/www/.*\.(css|scss|sass)$
# Keep dependency versions in sync w/ airflow/www/package.json
additional_dependencies: ['[email protected]',
'[email protected]']
+ - id: version-sync
+ name: Version sync
+ files: ^airflow/version.py$|setup.py
+ entry: ./scripts/ci/pre_commit/pre_commit_sync_version.sh
+ language: system
+ - id: providers-init-file
+ name: Provider init file
+ pass_filenames: false
+ always_run: false
+ entry: ./scripts/ci/pre_commit/pre_commit_check_providers_init.sh
+ language: system
Review comment:
It seems excessive to check this _every time_ we run pre-commit.
it's cheap sure, but it seems needless. Just add that
`airflow/providers/__init__.py` explicitly to .gitignore seems easier than
doing this
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
