potiuk commented on a change in pull request #12158:
URL: https://github.com/apache/airflow/pull/12158#discussion_r519174269
##########
File path: airflow/models/dagbag.py
##########
@@ -471,7 +471,7 @@ def collect_dags(
# file_stat.file similar format: /subdir/dag_name.py
# TODO: Remove for Airflow 2.0
filename = file_stat.file.split('/')[-1].replace('.py', '')
- Stats.timing(f'dag.loading-duration.{filename}',
file_stat.duration)
+ Stats.timing('dag.loading-duration.{filename}',
file_stat.duration, labels={"filename": filename})
Review comment:
Or maybe we should leave the old stats as they are and only add labels
in the new ones ? WDYT? We could even add some prefix/indication that those
stats are the "labeled" ones and distinguish them in the stats documentation ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
