mik-laj edited a comment on issue #4918: [AIRFLOW-4003] Extract example DAGs to separate pythons files URL: https://github.com/apache/airflow/pull/4918#issuecomment-473611245 I would prefer to make all changes in one PR. Creating new files should be combined with the creation of tests. Extracting fragments only to store them in another file is unintentional. This will only make it difficult to write documentation. You should extract the fragments and write tests, so that it would have an added value. I am proposing that you send PR to my PR. I will accept all your changes quickly, and finally I will add you as a co-author of the commit/PR. Answering your questions. 1. I made a DAG file out of it and selected the fragment that was needed in the documentation. This gives a real example of use. An example that can be tested. It is worth noting that I am working on a mechanism that allows us to see the full source code in the documentation. https://github.com/apache/airflow/pull/4894 2. In a perfect world, yes. We should prepare examples that should use the code fragments needed in the documentation. It is worth noting that the fragments can also be in the test files. https://github.com/googleapis/google-cloud-python/blob/51c97cd5ecf17d984be3f01cecd6e5d70ae1b266/bigquery/docs/snippets.py but the world is not always perfect.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
