feng-tao commented on a change in pull request #4926: [AIRFLOW-4104] Add type
annotations to common classes.
URL: https://github.com/apache/airflow/pull/4926#discussion_r266225905
##########
File path: airflow/hooks/base_hook.py
##########
@@ -67,7 +68,7 @@ def _get_connection_from_env(cls, conn_id):
return conn
@classmethod
- def get_connections(cls, conn_id):
+ def get_connections(cls, conn_id): # type: (str) -> Iterable[Connection]
Review comment:
In my other projects, we use the following syntax:
```
def get_connections(cls, conn_id : str) -> Iterable[Connection]:
```
I wonder whether there is a preferred style of mypy syntax.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
