mik-laj commented on a change in pull request #12183:
URL: https://github.com/apache/airflow/pull/12183#discussion_r519446800
##########
File path: airflow/www/templates/airflow/dags.html
##########
@@ -133,7 +133,7 @@ <h2>DAGs</h2>
</td>
{# Column 5: Dag Schedule #}
<td>
- <a class="label label-default schedule" href="{{
url_for('DagRunModelView.list') }}?_flt_3_dag_id={{ dag.dag_id }}">
+ <a class="label label-default schedule {{ dag.dag_id }}"
href="{{ url_for('DagRunModelView.list') }}?_flt_3_dag_id={{ dag.dag_id }}">
Review comment:
This can cause name conflicts. I think it's worth thinking about a
different selector in this case, e.g. based on the `data-dag-id` attribute.
```html
<a class="label label-default schedule" href="{{
url_for('DagRunModelView.list') }}?_flt_3_dag_id={{ dag.dag_id }}"
data-dag-id="{{ dag.dag_id }}">
```
```js
vaar dag_id = "my-dag-id"
document.querySelector('[data-dag-id="'+ dag_id+'"]')
```
See: https://issues.apache.org/jira/browse/AIRFLOW-6381
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
