kaxil commented on a change in pull request #11815: URL: https://github.com/apache/airflow/pull/11815#discussion_r519741276
########## File path: airflow/migrations/versions/45ba3f1493b9_add_k8s_yaml_to_rendered_templates.py ########## @@ -0,0 +1,52 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. + +"""add-k8s-yaml-to-rendered-templates + +Revision ID: 45ba3f1493b9 +Revises: 364159666cbd +Create Date: 2020-10-23 23:01:52.471442 + +""" + +import sqlalchemy_jsonfield +from alembic import op +from sqlalchemy import Column + +from airflow.settings import json + +# revision identifiers, used by Alembic. +revision = '45ba3f1493b9' +down_revision = '2c6edca13270' +branch_labels = None +depends_on = None + +__tablename__ = "rendered_task_instance_fields" +k8s_pod_yaml = Column('k8s_pod_yaml', sqlalchemy_jsonfield.JSONField(json=json), nullable=True) + + +def upgrade(): + """Apply add-k8s-yaml-to-rendered-templates""" + with op.batch_alter_table(__tablename__, schema=None) as batch_op: + batch_op.add_column(k8s_pod_yaml) Review comment: Actually, this is fine since you are passing the variable that is Column type which contains the type too on L40 I have tested in on MySQL too: ``` INFO [alembic.runtime.migration] Running upgrade 98271e7606e2 -> 52d53670a240, fix_mssql_exec_date_rendered_task_instance_fields_for_MSSQL INFO [alembic.runtime.migration] Running upgrade 52d53670a240 -> 849da589634d, Prefix DAG permissions. [2020-11-09 11:33:21,272] {manager.py:727} WARNING - No user yet created, use flask fab command to do it. [2020-11-09 11:33:29,248] {migration.py:515} INFO - Running upgrade 849da589634d -> 364159666cbd, Add creating_job_id to DagRun table [2020-11-09 11:33:29,282] {migration.py:515} INFO - Running upgrade 364159666cbd -> 2c6edca13270, Resource based permissions. [2020-11-09 11:33:29,340] {manager.py:727} WARNING - No user yet created, use flask fab command to do it. [2020-11-09 11:33:32,472] {migration.py:515} INFO - Running upgrade 2c6edca13270 -> 45ba3f1493b9, add-k8s-yaml-to-rendered-templates [2020-11-09 11:33:32,814] {dagbag.py:434} INFO - Filling up the DagBag from /root/airflow/dags ``` ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
