XD-DENG commented on a change in pull request #11970:
URL: https://github.com/apache/airflow/pull/11970#discussion_r520752980



##########
File path: UPDATING.md
##########
@@ -216,6 +216,28 @@ The previous option used a colon(`:`) to split the module 
from function. Now the
 
 The change aims to unify the format of all options that refer to objects in 
the `airflow.cfg` file.
 
+#### Unify user session lifetime configuration
+
+In previous version of Airflow user session lifetime could be configured by
+`session_lifetime_days` and `force_log_out_after` options. In practise only 
`session_lifetime_days`
+had impact on session lifetime, but it was limited to values in day.
+In Airflow 2.0 we have removed mentioned options and introduced new 
`session_lifetime_minutes`

Review comment:
       Hi @michalmisiewicz . Thanks for the update. 
   
   All look good to me other than a last point: this change update should be 
put under section `Airflow Master` of `UPDATING.md`, rather than `Airflow 
2.0.0a1`. The release manager(s) will decide when and which version to include 
this.
   
   May you please make this change? Please also remember to rebase to the 
latest Master branch. After that, I think we are good to merge.
   
   Thanks!




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to