XD-DENG commented on a change in pull request #12126:
URL: https://github.com/apache/airflow/pull/12126#discussion_r521670483
##########
File path: airflow/operators/dagrun_operator.py
##########
@@ -126,3 +144,22 @@ def execute(self, context: Dict):
dag.clear(start_date=self.execution_date,
end_date=self.execution_date)
else:
raise e
+
+ if self.wait_for_completion:
+ # wait for dag to complete
+ while True:
Review comment:
I'm thinking if it's making sense to have something like `max_retries`
or `timeout` here. Otherwise there is a chance that this becomes a dead loop in
extreme circumstances.
@turbaszek what do you think?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
