dimberman commented on a change in pull request #4852: [AIRFLOW-3152] Implements init-containers in Kubernetes Pod Operator URL: https://github.com/apache/airflow/pull/4852#discussion_r266542082
########## File path: airflow/contrib/kubernetes/init_container.py ########## @@ -0,0 +1,51 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. + + +class InitContainer: Review comment: I would agree with this, though I also imagine at some point soon we'll want to revamp this entire section to use the python SDK generated by kubernetes (that way we can allow users to submit a k8s pod object if there is a feature we are not offering). ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
