turbaszek commented on a change in pull request #12312:
URL: https://github.com/apache/airflow/pull/12312#discussion_r522871551
##########
File path: airflow/operators/python.py
##########
@@ -165,7 +166,7 @@ def __init__(
multiple_outputs: bool = False,
**kwargs,
) -> None:
- kwargs['task_id'] = self._get_unique_task_id(task_id,
kwargs.get('dag'))
+ kwargs['task_id'] = self._get_unique_task_id(task_id,
kwargs.get('dag'), kwargs.get('task_group'))
Review comment:
That was something I wanted suggest when we were doing the `@task` PR.
However, I like that we access the kwargs and then we pass them to super
constructor. Additionally they are not visible in signature so users don't have
to think about them. But no strong opinion on my side
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
