potiuk commented on issue #4543: [AIRFLOW-3718] [WIP] Multi-layered version of the docker image URL: https://github.com/apache/airflow/pull/4543#issuecomment-474049231 @dmberman - sure. I can. I imagine it's a a pain for reviewers to review it all. I am quite used to split and join vomits and re-arrange branches as needed. So this should be no big problem. It actually make sense to split it as some of the changes might wait until all the tests are fixed. I already thought about it and I think this approach might make sense: 1) first replace the original Docker with the multi-layered one (plus accompanying .ignore files) - the Dockerfile will build stand-alone and in DockerHub and will produce similar Docker image as we have currently. I can even extract out the CI-relevant stage and submit it at later PR 2) then as next PR I can add hook/build scripts that will add custom build in DockerHub and produce both CI And Airflow images - at this time I could add the CI stage back. 3) next PR would be to change tests to use the new Dockerfile/images to run Travis tests. 4) final PR (which i already split to separate PR) is the improved development environment. It will be difficult to split it to more granular changes I am afraid, but having those four PRs might actually make sense - also it might make it easier to introduce it - we can check step by step that things work/reconfigure the DockerHub gradually and verify that it works fine. Do you think such split will address your concern? Or you thought about more incremental approach ? @fokko @ashb - what do you think ?
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
