turbaszek commented on pull request #12327:
URL: https://github.com/apache/airflow/pull/12327#issuecomment-726707793


   > Ahhh yeah, def not something we want. This wasn't clear to me from this 
PR. If I'm understanding the problem there are actually two issues we need to 
address:
   > 
   > 1. Looking at the Xcom list page would request a bunch of files from GCS 
bucket (in your example)
   > 2. Even if that was "cheap"/cached(/whatever), we don't want to display 
huge xcom payloads _anyway_.
   > 
   > Have I summarised the problem correctly?
   
   Yes, thanks for making it clearer!
   
   > How about something clearer in intent -- something like 
`get_xcom_summary`? 
   
   Summary suggest that we return something more than one value (for example 
summary in pandas), how about `get_raw_value`? 
   
   > From reading the PR/code it this PR it wasn't clear when this new feature 
would actually be used.
   
   To be honest I don't think overriding how to reconstruct ORM model is 
something that should be clear / suggested to users (although should be 
configurable to fully customise the XCom). I suppose that in 95% cases using 
the `BaseXCom` method should be ok and that's what we would use by default. 
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to